New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project_ methods from the externs module #10955

Merged

gshuflin merged 6 commits into pantsbuild:master from gshuflin:remote-project-methods

Oct 16, 2020

Contributor

gshuflin commented Oct 13, 2020 •

edited

This commit removes all the project_ functions in externs in favor of externs::getattr with type specialization at each callsite. project_frozendict and project_str both have a little bit of custom logic, so it makes sense to leave these two functions alone, although they have been renamed to getattr_from_frozendict and getattr_as_string to make it clear that these functions are variations on the fundamental getattr operation.

gshuflin requested review from jsirois, tdyas and Eric-Arellano

October 13, 2020 04:50

cosmicexplorer reviewed

View reviewed changes

src/rust/engine/src/externs/mod.rs Outdated Show resolved Hide resolved

coveralls commented Oct 13, 2020 •

edited

Coverage remained the same at 0.0% when pulling 093deb3 on gshuflin:remote-project-methods into 348b228 on pantsbuild:master.

gshuflin force-pushed the remote-project-methods branch from cf1c62e to 093deb3 Compare

October 13, 2020 19:55

gshuflin changed the title ~~Remove most project_ methods from the externs module~~ Remove project_ methods from the externs module

Eric-Arellano approved these changes

View reviewed changes

Contributor

Eric-Arellano left a comment

Thanks! Big improvement.

gshuflin added 6 commits

October 16, 2020 14:23


          Remove project_ methods

5ac6e4e

[ci skip-build-wheels]


          multi_str

849c337

[ci skip-build-wheels]


          remove project_iterable

57ddb6b

[ci skip-build-wheels]


          Remove nailgun TODO

7bf0b3c

[ci skip-build-wheels]


          Rename function

eeefb6d

[ci skip-build-wheels]


          Rename to getattr_

5b5cab2

[ci skip-build-wheels]

gshuflin force-pushed the remote-project-methods branch from 093deb3 to 5b5cab2 Compare

October 16, 2020 21:23

gshuflin merged commit ac8561b into pantsbuild:master

gshuflin deleted the remote-project-methods branch

October 16, 2020 22:24

gshuflin mentioned this pull request

Prepare 2.1.0.dev0 #11089

Merged

gshuflin added a commit that referenced this pull request


          Prepare 2.1.0.dev0 (#11089)

bf5e789

Internal-only changes: 

* upgrade to cpython crate v0.5.1 (#11052)
  `PR #11052 <https://github.com/pantsbuild/pants/pull/11052>`_

* Prepare 2.0.0 (#11053)
  `PR #11053 <https://github.com/pantsbuild/pants/pull/11053>`_

* Revert "Add new EngineAware method metadata() (#11030)" (#11047)
  `PR #11030 <https://github.com/pantsbuild/pants/pull/11030>`_
  `PR #11047 <https://github.com/pantsbuild/pants/pull/11047>`_

* Remove deprecated `python_binary` target in favor of `pex_binary` (#11046)
  `PR #11046 <https://github.com/pantsbuild/pants/pull/11046>`_

* Prepare 2.0.0rc3 (#11044)
  `PR #11044 <https://github.com/pantsbuild/pants/pull/11044>`_

* Eagerly validate entry points for `setup_py().with_binaries()` (#11034)
  `PR #11034 <https://github.com/pantsbuild/pants/pull/11034>`_
  `PR #11021 <https://github.com/pantsbuild/pants/pull/11021>`_

* Use Ubuntu Bionic for CI (#11027)
  `PR #11027 <https://github.com/pantsbuild/pants/pull/11027>`_

* Prepare 2.0.0rc2 (#11017)
  `PR #11017 <https://github.com/pantsbuild/pants/pull/11017>`_

* Remove RunTrackerLogger (#11018)
  `PR #11018 <https://github.com/pantsbuild/pants/pull/11018>`_

* Upgrade Pex to 2.1.20 (#11014)
  `PR #11014 <https://github.com/pantsbuild/pants/pull/11014>`_

* Remove more unused code from RunTracker (#11012)
  `PR #11012 <https://github.com/pantsbuild/pants/pull/11012>`_

* Add type annotations to AggregatedTimings (#11009)
  `PR #11009 <https://github.com/pantsbuild/pants/pull/11009>`_

* Increase default `[python-setup].resolver_jobs` to `cpu_count / 2` (#11006)
  `PR #11006 <https://github.com/pantsbuild/pants/pull/11006>`_

* Include `<PYENV>` in `[python-setup].interpreter_search_paths` default (#10998)
  `PR #10998 <https://github.com/pantsbuild/pants/pull/10998>`_

* Remove PantsDaemonStats class wrapper (#11003)
  `PR #11003 <https://github.com/pantsbuild/pants/pull/11003>`_
  `PR #files#r508861045 <https://github.com/pantsbuild/pants/pull/11000/files#r508861045>`_

* Revert using libCST for dep inference due to performance (#10907) (#11001)
  `PR #10907 <https://github.com/pantsbuild/pants/pull/10907>`_
  `PR #11001 <https://github.com/pantsbuild/pants/pull/11001>`_


* Run tracker refactor (#11000)
  `PR #11000 <https://github.com/pantsbuild/pants/pull/11000>`_

* refactor Core::new including command runner setup (#10993)
  `PR #10993 <https://github.com/pantsbuild/pants/pull/10993>`_
  `PR #10960 <https://github.com/pantsbuild/pants/pull/10960>`_

* Allow changing the versioning scheme for `python_distribution` first-party dependencies (#10977)
  `PR #10977 <https://github.com/pantsbuild/pants/pull/10977>`_

* Remove tokio Handle type from Executor::new (#10980)
  `PR #10980 <https://github.com/pantsbuild/pants/pull/10980>`_

* Remove deprecated `Address.parse()` and `Address.reference()` (#10981)
  `PR #10981 <https://github.com/pantsbuild/pants/pull/10981>`_

* Remove project_ methods from the externs module (#10955)
  `PR #10955 <https://github.com/pantsbuild/pants/pull/10955>`_

* Prepare 2.0.0rc1 (#10972)
  `PR #10972 <https://github.com/pantsbuild/pants/pull/10972>`_

* Fix interpreter selection when building a PEX to use `[python-setup].interpreter_search_paths` (#10965)
  `PR #10965 <https://github.com/pantsbuild/pants/pull/10965>`_

* Delete `JsonReporter` (#10964)
  `PR #10964 <https://github.com/pantsbuild/pants/pull/10964>`_

* Fix log (#10959)
  `PR #10959 <https://github.com/pantsbuild/pants/pull/10959>`_

* Expose getattr method for Python-related APIs (#10953)
  `PR #10953 <https://github.com/pantsbuild/pants/pull/10953>`_

* Upgrade tokio package to 0.2.22 (#10949)
  `PR #10949 <https://github.com/pantsbuild/pants/pull/10949>`_

* Use `package` to build Pants's wheels, rather than `setup-py` (#10947)
  `PR #10947 <https://github.com/pantsbuild/pants/pull/10947>`_

* Simplify val_to_str and have it and val_to_log_level use PyObject (#10946)
  `PR #10946 <https://github.com/pantsbuild/pants/pull/10946>`_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment