Two enhancements to tailor. #11625
Two enhancements to tailor. #11625
Conversation
1. We require root-level targets to be explicitly named, so this change makes tailor take care of that. 2. It's possible for directory named BUILD to collide with a file we want to create under the same name. This is not as unlikely as you may think on systems where paths are case-insensitive, such as MacOS. This change detects this case and renames the BUILD file. [ci skip-rust] [ci skip-build-wheels]
|
PS I encountered both these cases in the real world while running |
There was a problem hiding this comment.
Excellent! Maybe BUILD.pants instead of .alt? I'm trying to think of a name that would make sense to a first-time user who doesn't realize why this is happening.
Or, maybe log detected directory named build, using the BUILD file name BUILD.pants instead? It would break the comprehension you have there, but the clarity could be helpful.
| @@ -141,6 +141,28 @@ def test_rename_conflicting_targets(rule_runner: RuleRunner) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def test_root_targets_are_explicitly_named(rule_runner: RuleRunner) -> None: | |||
| rule_runner.create_file("foo.f90", "") | |||
There was a problem hiding this comment.
No need to waste CI time fixing this, but FYI the content takes a default arg and you can leave that off.
There was a problem hiding this comment.
I prefer to be explicit anyway.
[ci skip-rust] [ci skip-build-wheels]
|
Changed the alt extension to ".pants", but I didn't add logging since it will be outside the flow of the normal goal output. It's not a super-common case and I think it'll be reasonably obvious why. Certainly if anyone tries to rename the file... |
1. We require root-level targets to be explicitly named, so this change makes tailor take care of that. 2. It's possible for directory named BUILD to collide with a file we want to create under the same name. This is not as unlikely as you may think on systems where paths are case-insensitive, such as MacOS. This change detects this case and renames the BUILD file. [ci skip-rust] [ci skip-build-wheels]
* Two enhancements to tailor. (#11625) 1. We require root-level targets to be explicitly named, so this change makes tailor take care of that. 2. It's possible for directory named BUILD to collide with a file we want to create under the same name. This is not as unlikely as you may think on systems where paths are case-insensitive, such as MacOS. This change detects this case and renames the BUILD file. * Ensure that ancestor files at the buildroot are found. (#11632) Previously we would find ancestor files correctly all the way to the source root, and even above, but would stop short at the buildroot. However there are real-world cases in which the buildroot is the source root, and can contain, e.g., conftest.py files which we fail to discover. This change fixes this oversight. [ci skip-rust] [ci skip-build-wheels]
We require root-level targets to be
explicitly named, so this change makes tailor
take care of that.
It's possible for directory named BUILD to collide
with a file we want to create under the same name.
This is not as unlikely as you may think on systems
where paths are case-insensitive, such as MacOS.
This change detects this case and renames the BUILD
file.
[ci skip-rust]
[ci skip-build-wheels]