Ensure that ancestor files at the buildroot are found. #11632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would find ancestor files correctly all the way to the source root, and even above, but would stop short at the buildroot. However there are real-world cases in which the buildroot is the source root, and can contain, e.g., conftest.py files which we fail to discover. This change fixes this oversight. [ci skip-rust] [ci skip-build-wheels]
stuhood
approved these changes
Mar 4, 2021
|
Merging based on the green Travis build, the test failure on GHA is a flake that we should investigate separately. |
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Mar 4, 2021
) Previously we would find ancestor files correctly all the way to the source root, and even above, but would stop short at the buildroot. However there are real-world cases in which the buildroot is the source root, and can contain, e.g., conftest.py files which we fail to discover. This change fixes this oversight. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
that referenced
this pull request
Mar 4, 2021
* Two enhancements to tailor. (#11625) 1. We require root-level targets to be explicitly named, so this change makes tailor take care of that. 2. It's possible for directory named BUILD to collide with a file we want to create under the same name. This is not as unlikely as you may think on systems where paths are case-insensitive, such as MacOS. This change detects this case and renames the BUILD file. * Ensure that ancestor files at the buildroot are found. (#11632) Previously we would find ancestor files correctly all the way to the source root, and even above, but would stop short at the buildroot. However there are real-world cases in which the buildroot is the source root, and can contain, e.g., conftest.py files which we fail to discover. This change fixes this oversight. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would find ancestor files correctly all the
way to the source root, and even above, but would stop short
at the buildroot.
However there are real-world cases in which the buildroot is
the source root, and can contain, e.g., conftest.py files which
we fail to discover.
This change fixes this oversight.
[ci skip-rust]
[ci skip-build-wheels]