Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check parent directories too for config files for tools Pants runs #11992

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

Eric-Arellano
Copy link
Contributor

This audits each tool to make sure we are properly capturing all their config files. For now, we only warn if we detect them and they're not configured, but soon we will autodiscover them.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eric-Arellano Eric-Arellano merged commit 04819a1 into pantsbuild:main Apr 30, 2021
@Eric-Arellano Eric-Arellano deleted the config-argv branch April 30, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants