Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous telemetry logging. #12340

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jul 13, 2021

Previously, when completing asynchronously, the log messages would not show on the console.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood
Copy link
Sponsor Member

stuhood commented Jul 13, 2021

Now that #12338 has landed, CI should be able to make progress. I've restarted the shards, but if Github doesn't automatically rebase those, will need to rebase manually.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
@benjyw benjyw merged commit 990be5c into pantsbuild:main Jul 14, 2021
@benjyw benjyw deleted the fix_telemetry_logging branch July 14, 2021 03:22
benjyw added a commit to benjyw/pants that referenced this pull request Jul 14, 2021
Previously, when completing asynchronously, the log messages would not show on the console.

[ci skip-rust]
[ci skip-build-wheels]
benjyw added a commit to benjyw/pants that referenced this pull request Jul 14, 2021
Previously, when completing asynchronously, the log messages would not show on the console.

[ci skip-rust]
[ci skip-build-wheels]
benjyw added a commit that referenced this pull request Jul 14, 2021
Cherrypick of #12340. 

Previously, when completing asynchronously, the log messages would not show on the console.

[ci skip-rust]
[ci skip-build-wheels]
benjyw added a commit that referenced this pull request Jul 14, 2021
Cherrypick of #12340.

Previously, when completing asynchronously, the log messages would not show on the console.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants