Issue/10944 pep561 py typed 2 #12842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se> [ci skip-rust] [ci skip-build-wheels]
Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se> # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Added the cherry-pick label, as I think this is a rather unobtrusive change, but adds a much needed feature in order to write pants plugins effectively. Feel free to disagree ;) |
Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se> # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
kaos
added a commit
to kaos/pants
that referenced
this pull request
Sep 12, 2021
…EP-561 (pantsbuild#12842) Closes pantsbuild#10944 Supersedes pantsbuild#12330, pantsbuild#12751 This adds `py.typed` to `pantsbuild.pants` and `pantsbuild.pants.testutil`, with integration test verifying that typecheck works as expected for both distributions. I've verified that the tests fail as expected when excluding the dependency on the `py_typed` resource. (cherry picked from commit 4f437a4) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10944 Supersedes #12330, #12751
This adds
py.typedtopantsbuild.pantsandpantsbuild.pants.testutil, with integration test verifying that typecheck works as expected for both distributions.I've verified that the tests fail as expected when excluding the dependency on the
py_typedresource.