Support linux arm64 binary tools. #13249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to differentiate the architecture, and adds defaults for all binary tools that have an arm64 release, or that I was able to build on that architecture. The only tool that does not currently build on linux arm64 is Hadolint. [ci skip-rust] [ci skip-build-wheels]
benjyw
commented
Oct 13, 2021
| @@ -23,18 +23,20 @@ class SuccinctCodeCounter(TemplatedExternalTool): | |||
| options_scope = "scc" | |||
| help = "The Succinct Code Counter, aka `scc` (https://github.com/boyter/scc)." | |||
|
|
|||
| default_version = "2.12.0" | |||
| default_version = "3.0.0" | |||
There was a problem hiding this comment.
Upgraded to a version that has arm64 binaries (for MacOS and Linux) in its release.
benjyw
commented
Oct 13, 2021
| f"{default_version}|macos_arm64 |b080c3b659f7286e27004aa33759664d91e15ef2498ac709a452445d47e3ac23|1348272", | ||
| f"{default_version}|macos_x86_64|b080c3b659f7286e27004aa33759664d91e15ef2498ac709a452445d47e3ac23|1348272", | ||
| f"{default_version}|linux_x86_64|64f17152d96d7ec261ad3086ed42d18232fcb65148b44571b564d688269d36c8|1443836", | ||
| "v0.7.1|macos_arm64 |b080c3b659f7286e27004aa33759664d91e15ef2498ac709a452445d47e3ac23|1348272", |
There was a problem hiding this comment.
Got rid of the interpolation in favor of hardcoding the version in each string, for the following reasons:
- It actually makes the line shorter and more readable.
default_known_versionscan in principle contain additional versions other thandefault_version, and this emphasizes that fact.- We don't want casual readers to think that just updating
default_versionis sufficient. This emphasizes that each binary must be updated.
benjyw
commented
Oct 13, 2021
| @@ -12,6 +12,7 @@ | |||
|
|
|||
|
|
|||
| class Platform(Enum): | |||
| linux_arm64 = "linux_arm64" | |||
There was a problem hiding this comment.
I verified on an arm64 instance that this platform is correctly detected.
kaos
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to differentiate the architecture, and adds
defaults for all binary tools that have an arm64 release, or that
I was able to build on that architecture.
The only tool that does not currently build on linux arm64 is Hadolint.
[ci skip-rust]
[ci skip-build-wheels]