Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse SSH git requirements in poetry config. #13344

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Oct 23, 2021

Reqs of the form git@github.com:foo/bar.git must be rewritten to
ssh://git@github.com/foo/bar.git to become valid PEP 440 requirements.

[ci skip-rust]

[ci skip-build-wheels]

Reqs of the form git@github.com:foo/bar.git must be rewritten
to ssh://git@github.com/foo/bar.git to become valid PEP 440 requirements.

[ci skip-rust]

[ci skip-build-wheels]
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Oct 23, 2021

I've manually verified that these are equivalent in Poetry:

ansicolors = {git = "git@github.com:jonathaneunice/colors.git"}

vs.

ansicolors = {git = "ssh://git@github.com/jonathaneunice/colors.git"}

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benjyw benjyw merged commit 8a28934 into pantsbuild:main Oct 25, 2021
@benjyw benjyw deleted the parse_ssh_poetry_reqs branch October 25, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants