[jvm] Fix parsing of Coursier report coordinates when packaging is reported.
#13996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Dec 27, 2021
stuhood
deleted the
stuhood/fix-parsing-of-coursier-report-coordinates
branch
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Dec 27, 2021
…s reported. (pantsbuild#13996) As reported in pantsbuild#13986, artifacts with `packaging` specified in their POMs currently parse incorrectly from the `Coursier` report. While we wait for clarity upstream in coursier/coursier#2315, optionally apply fixed parsing in the relevant positions. Fixes pantsbuild#13986. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Dec 27, 2021
…s reported. (cherrypick of #13996) (#13998) As reported in #13986, artifacts with `packaging` specified in their POMs currently parse incorrectly from the `Coursier` report. While we wait for clarity upstream in coursier/coursier#2315, optionally apply fixed parsing in the relevant positions. Fixes #13986. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
that referenced
this pull request
Dec 28, 2021
This goes on top of #13996 removing the workaround on the maven coordinates after finding out that coursier's behaviour (reported at coursier/coursier#2315) is the correct one. While I haven't found any _spec_ of that, this is what I gather from [this Maven document](https://maven.apache.org/plugins/maven-assembly-plugin/examples/single/including-and-excluding-artifacts.html) and from inspecting other implementations. This PR parses the Maven coordinates using a regular expression that is able to extract the packaging and classifier in case they are present. This should make it compatible with artifacts that only display three of the elements and with the ones that even include the classifier in it.
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Dec 28, 2021
) This goes on top of pantsbuild#13996 removing the workaround on the maven coordinates after finding out that coursier's behaviour (reported at coursier/coursier#2315) is the correct one. While I haven't found any _spec_ of that, this is what I gather from [this Maven document](https://maven.apache.org/plugins/maven-assembly-plugin/examples/single/including-and-excluding-artifacts.html) and from inspecting other implementations. This PR parses the Maven coordinates using a regular expression that is able to extract the packaging and classifier in case they are present. This should make it compatible with artifacts that only display three of the elements and with the ones that even include the classifier in it. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Dec 28, 2021
…14010) (#14015) This goes on top of #13996 removing the workaround on the maven coordinates after finding out that coursier's behaviour (reported at coursier/coursier#2315) is the correct one. While I haven't found any _spec_ of that, this is what I gather from [this Maven document](https://maven.apache.org/plugins/maven-assembly-plugin/examples/single/including-and-excluding-artifacts.html) and from inspecting other implementations. This PR parses the Maven coordinates using a regular expression that is able to extract the packaging and classifier in case they are present. This should make it compatible with artifacts that only display three of the elements and with the ones that even include the classifier in it. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #13986, artifacts with
packagingspecified in their POMs currently parse incorrectly from theCoursierreport. While we wait for clarity upstream in coursier/coursier#2315, optionally apply fixed parsing in the relevant positions. Fixes #13986.[ci skip-rust]
[ci skip-build-wheels]