Warn when [python-protobuf].runtime_dependencies needs to use new target generator syntax
#14391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
…arget generator syntax # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Feb 7, 2022
Comment on lines
+222
to
+225
| check(python_thrift.runtime_dependencies, "[python-thrift].runtime_dependencies") | ||
| check(flake8.source_plugins, "[flake8].source_plugins") | ||
| check(pylint.source_plugins, "[pylint].source_plugins") | ||
| check(mypy.source_plugins, "[mypy].source_plugins") |
There was a problem hiding this comment.
It's unlikely that these options will have bad references, but it's cheap for us to check.
stuhood
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning looks like:
Many thanks to @jyggen for pointing out this edge case!