Add lint --skip-formatters option
#15427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
approved these changes
May 12, 2022
| default=False, | ||
| help=softwrap( | ||
| f""" | ||
| If true, skip running all formatters in check-only mode. |
There was a problem hiding this comment.
Can we just call it "lint mode"?
There was a problem hiding this comment.
Perhaps? I think lint is generally not super well understood and it might be a tautology? I'm thinking check-only mode may be clearer.
There was a problem hiding this comment.
My only heartburn comes from the fact that Pants has a check goal. check-if-changed mode?
turbo minor feel free to drop :)
|
Oh wait, dang it. This should probably be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14460.
[ci skip-rust]
[ci skip-build-wheels]