Proposal for a Helm Deployment goal implementation #15882

alonsodomin · 2022-06-21T08:26:53Z

This is the PoC implementation for the proposal of a Helm Deployment goal. Design document can be found in:

https://docs.google.com/document/d/17wZRjiIxM5918ybC_0EnKY42qwd47-1ZporBdua8vRQ/edit?usp=sharing

src/python/pants/backend/helm/subsystems/BUILD

src/python/pants/core/goals/deploy.py

stuhood

Thanks! I didn't review the helm implementation, only the deploy goal itself: let us know when you're ready to move forward with that portion.

src/python/pants/core/goals/deploy.py

alonsodomin · 2022-07-21T07:27:05Z

Reworked the implementation of the core deploy goal.

The new implementation obtains a single DeployProcess per DeployFieldSet and goes one by one finding their publish dependencies, which will be published before invoking the deploy process.

If publishing of any of the deploy dependencies fails, then that deployment is skipped. In previous implementation, the whole goal would exit at that point.

src/python/pants/core/goals/deploy.py

src/python/pants/backend/helm/util_rules/manifest.py

tdyas · 2022-07-28T02:08:53Z

I prefer to see the core deploy goal land as a separate PR, mainly to make it easier to review. This PR is a bit large as it is. Thoughts?

alonsodomin · 2022-07-28T08:39:00Z

@tdyas yeah, perfectly normal to understand, the implemented machinery in the Helm side has quite a few moving pieces.

Will create a PR for the core deploy goal only

alonsodomin · 2022-07-28T09:29:59Z

core deploy implementation has been submitted as the PR #16335 separately

cognifloyd

I have only reviewed documentation for now. I'll check out implementation details another day.

I have several wording suggestions for the docs and a few questions about how things work.

docs/markdown/Helm/helm-deployments.md

alonsodomin · 2022-07-29T06:50:03Z

first of all, thanks a lot for proof reading the documentation, this was very helpful!

Extracted from #15882, this provides with the minimal implementation of a `deploy` goal.

alonsodomin · 2022-08-04T13:19:10Z

the core deploy implementation has been removed from this PR as it has already been merged in a separate PR.

stuhood

Thanks! Solid work.

docs/markdown/Helm/helm-deployments.md

pants.toml

src/python/pants/backend/helm/dependency_inference/deployment.py

src/python/pants/backend/helm/subsystems/helm.py

src/python/pants/backend/helm/subsystems/k8s_parser.py

src/python/pants/backend/helm/target_types.py

src/python/pants/backend/helm/util_rules/tool.py

src/python/pants/backend/helm/utils/docker.py

cognifloyd · 2022-08-04T17:30:34Z

Does this support deploying an external chart? Or does the chart have to be embedded in the repo?

…m deployment

Co-authored-by: Stu Hood <stuhood@gmail.com>

Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>

Extracted from pantsbuild#15882, this provides with the minimal implementation of a `deploy` goal.

Implementation for the proposal of a Helm Deployment goal. Design document can be found in: https://docs.google.com/document/d/17wZRjiIxM5918ybC_0EnKY42qwd47-1ZporBdua8vRQ/edit?usp=sharing

stuhood · 2022-10-21T23:16:44Z

Does this support deploying an external chart? Or does the chart have to be embedded in the repo?

I believe that #16478 added support for external charts?

alonsodomin · 2022-10-22T04:42:19Z

Yes, deploying third party charts was in that PR.

alonsodomin added the category:new feature label Jun 21, 2022

alonsodomin force-pushed the helm_install branch from 6e11b9d to 6091ed2 Compare June 25, 2022 22:10

alonsodomin force-pushed the helm_install branch 2 times, most recently from e8c71aa to ce9d2d8 Compare July 15, 2022 13:09

alonsodomin commented Jul 19, 2022

View reviewed changes

src/python/pants/backend/helm/subsystems/BUILD Show resolved Hide resolved

src/python/pants/core/goals/deploy.py Outdated Show resolved Hide resolved

alonsodomin added the category:user api change label Jul 19, 2022

alonsodomin requested review from kaos, stuhood and Eric-Arellano July 19, 2022 15:05

stuhood reviewed Jul 19, 2022

View reviewed changes

src/python/pants/core/goals/deploy.py Outdated Show resolved Hide resolved

src/python/pants/core/goals/deploy.py Outdated Show resolved Hide resolved

src/python/pants/core/goals/deploy.py Outdated Show resolved Hide resolved

alonsodomin removed the category:user api change label Jul 20, 2022

alonsodomin commented Jul 21, 2022

View reviewed changes

src/python/pants/core/goals/deploy.py Outdated Show resolved Hide resolved

alonsodomin requested a review from tdyas July 27, 2022 11:00

tdyas reviewed Jul 28, 2022

View reviewed changes

src/python/pants/backend/helm/util_rules/manifest.py Outdated Show resolved Hide resolved

alonsodomin mentioned this pull request Jul 28, 2022

Provide foundations for a deploy goal #16335

Merged

cognifloyd reviewed Jul 28, 2022

View reviewed changes

alonsodomin force-pushed the helm_install branch 3 times, most recently from e8f14f3 to 0a9eae6 Compare August 2, 2022 14:51

stuhood pushed a commit that referenced this pull request Aug 3, 2022

Provide foundations for a deploy goal (#16335)

60e7af6

Extracted from #15882, this provides with the minimal implementation of a `deploy` goal.

alonsodomin force-pushed the helm_install branch from 6ed30c3 to 51ea939 Compare August 3, 2022 14:04

stuhood approved these changes Aug 4, 2022

View reviewed changes

alonsodomin force-pushed the helm_install branch from 9b2e06b to 0e8923e Compare August 5, 2022 09:16

alonsodomin and others added 20 commits August 10, 2022 09:30

Remove deprecated usage of InteractiveProcessRequest

f491645

Make intermediate renderer type private

7319fcf

Fix imports after rebase

dfd7fc7

Add assertion to prevent executing a side-effect when rendering a Hel…

d7d280a

…m deployment

Define passthrough arguments in the helm scope

c5f4556

Fix problems after rebasing

8477d1e

Initial scripts for the kubernetes manifest parser

b44ad52

Use a third-party library for parsing kube manifests

a68feef

Add test for YamlPath class

15d4125

Remove commented out code

406ad87

Fix description in k8s parser process

f7e6076

Update docs/markdown/Helm/helm-deployments.md

8805aae

Co-authored-by: Stu Hood <stuhood@gmail.com>

Update docs/markdown/Helm/helm-deployments.md

6084c4b

Co-authored-by: Stu Hood <stuhood@gmail.com>

Update src/python/pants/backend/helm/subsystems/helm.py

acdccd3

Co-authored-by: Stu Hood <stuhood@gmail.com>

Update src/python/pants/backend/helm/target_types.py

7efb12a

Co-authored-by: Stu Hood <stuhood@gmail.com>

Do not send the whole Snapshot when parsing individual files

2b02d6c

Address review comments

0c1aca8

Update src/python/pants/backend/helm/subsystems/k8s_parser.py

80fce39

Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>

Update src/python/pants/backend/helm/subsystems/post_renderer_main.py

c87a17b

Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>

Remove unnecessary core fields

7432b29

alonsodomin force-pushed the helm_install branch from ea397b5 to 7432b29 Compare August 10, 2022 07:36

alonsodomin added 3 commits August 10, 2022 10:27

Format code

cafabde

Update text copy on value files

ca332ed

Add test to k8s parser for resources not using Docker images

fb94975

alonsodomin merged commit bac3e04 into pantsbuild:main Aug 10, 2022

cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022

Provide foundations for a deploy goal (pantsbuild#16335)

70667b7

Extracted from pantsbuild#15882, this provides with the minimal implementation of a `deploy` goal.

huonw mentioned this pull request Jul 12, 2023

Prepare 2.18.0a0 huonw/pants#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposal for a Helm Deployment goal implementation #15882

Proposal for a Helm Deployment goal implementation #15882

alonsodomin commented Jun 21, 2022

stuhood left a comment

alonsodomin commented Jul 21, 2022 •

edited

tdyas commented Jul 28, 2022

alonsodomin commented Jul 28, 2022

alonsodomin commented Jul 28, 2022

cognifloyd left a comment

alonsodomin commented Jul 29, 2022

alonsodomin commented Aug 4, 2022

stuhood left a comment •

edited

cognifloyd commented Aug 4, 2022

stuhood commented Oct 21, 2022

alonsodomin commented Oct 22, 2022

Proposal for a Helm Deployment goal implementation #15882

Proposal for a Helm Deployment goal implementation #15882

Conversation

alonsodomin commented Jun 21, 2022

stuhood left a comment

Choose a reason for hiding this comment

alonsodomin commented Jul 21, 2022 • edited

tdyas commented Jul 28, 2022

alonsodomin commented Jul 28, 2022

alonsodomin commented Jul 28, 2022

cognifloyd left a comment

Choose a reason for hiding this comment

alonsodomin commented Jul 29, 2022

alonsodomin commented Aug 4, 2022

stuhood left a comment • edited

Choose a reason for hiding this comment

cognifloyd commented Aug 4, 2022

stuhood commented Oct 21, 2022

alonsodomin commented Oct 22, 2022

alonsodomin commented Jul 21, 2022 •

edited

stuhood left a comment •

edited