Support 3rd party Helm artifacts in Helm deployments #16478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Aug 11, 2022
| release_name = request.field_set.release_name.value or request.field_set.address.target_name | ||
| release_name = ( | ||
| request.field_set.release_name.value | ||
| or request.field_set.address.target_name.replace("_", "-") |
There was a problem hiding this comment.
Is this a Helm convention to use dashes not underscores?
There was a problem hiding this comment.
yes, and it's also forbidden to use underscores to name a release, so the easy way out was transforming them into dashes...
benjyw
approved these changes
Aug 13, 2022
| ```python src/deploy/BUILD | ||
| helm_deployment( | ||
| name="main", | ||
| dependencies=["//3rdparty/helm/jetstack:cert-manager"], |
There was a problem hiding this comment.
How hard would it be to add dependency inference for helm_artifacts?
There was a problem hiding this comment.
In the deployments is not possible to infer the chart, first or third party. Deployments are basically a set of YAML files and settings with no info on what chart they are meant to be used on.
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Allows referencing a `helm_artifact` target in the `dependencies` field of a `helm_deployment`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16477