Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scala plugins args order causing cache issues #16228

Merged
merged 2 commits into from Jul 19, 2022
Merged

fix scala plugins args order causing cache issues #16228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c27f82
fix scala plugins args order causing cache issues
somdoron Jul 19, 2022
3c6d1af
use OrderedSet instead of set to solve non-determinstic order of targets
somdoron Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/python/pants/backend/scala/compile/scalac_plugins.py
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@
from pants.jvm.resolve.key import CoursierResolveKey
from pants.jvm.subsystems import JvmSubsystem
from pants.jvm.target_types import JvmResolveField
from pants.util.ordered_set import OrderedSet


@dataclass(frozen=True)
Expand Down Expand Up @@ -55,8 +56,8 @@ def from_target_plugins(
seq: Iterable[ScalaPluginTargetsForTarget],
resolve: CoursierResolveKey,
) -> ScalaPluginsRequest:
plugins: set[Target] = set()
artifacts: set[Target] = set()
plugins: OrderedSet[Target] = OrderedSet()
artifacts: OrderedSet[Target] = OrderedSet()

for spft in seq:
plugins.update(spft.plugins)
Expand Down