fix scala plugins args order causing cache issues #16228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
somdoron
force-pushed
the
scala_plugins_order
branch
from
a094a35
to
5c27f82
Compare
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Thanks a lot for investigating this!
As discussed offline, I'd like to prevent these issues holistically via #14195 (comment), so I'm fine not having a test for now.
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Jul 19, 2022
Use `OrderedSet` instead of `set` to solve non-determinstic order of targets. See pantsbuild#14195 (comment) for followup. [ci skip-rust] [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Jul 19, 2022
Use `OrderedSet` instead of `set` to solve non-determinstic order of targets. See pantsbuild#14195 (comment) for followup. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
pushed a commit
that referenced
this pull request
Jul 19, 2022
) (#16234) fix scala plugins args order causing cache issues (#16228) Use `OrderedSet` instead of `set` to solve non-determinstic order of targets. See #14195 (comment) for followup. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Doron Somech <somdoron@gmail.com>
stuhood
added a commit
that referenced
this pull request
Jul 20, 2022
) (#16233) Use `OrderedSet` instead of `set` to solve non-determinstic order of targets. See #14195 (comment) for followup. [ci skip-rust] [ci skip-build-wheels]
jyggen
pushed a commit
to jyggen/pants
that referenced
this pull request
Jul 27, 2022
Use `OrderedSet` instead of `set` to solve non-determinstic order of targets. See pantsbuild#14195 (comment) for followup. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
OrderedSetinstead ofsetto solve non-determinstic order of targets. See #14195 (comment) for followup.[ci skip-rust]
[ci skip-build-wheels]