go: analyze imports paths by module to enable multiple go_mod targets (Cherry pick of #16386) #16799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2022 12:40
…pantsbuild#16386) The package mapping from import path to addresses (`ImportPathToPackages`) was global to the entire repository and not split by Go module. This prevented using multiple Go modules in a single repository. This PR solves the issue by introducing `GoImportPathMappingRequest` which allows the package mapping to be requested per module. That per-module mapping relies on a repository-wide mapping available as `AllGoModuleImportPathsMappings`. The `GoModuleImportPathsMappingsHook` union allows plugins to provide their own import path mappings. For example, this support is now used by the protobuf/go codegen backend to supply import paths from generated protobuf code, meaning that the Go backend is able to infer dependencies between Go code and protobuf code automatically. Fixes pantsbuild#13114. [ci skip-rust]
[ci skip-rust] [ci skip-build-wheels]
|
The cherry pick was not clean due to the |
tdyas
commented
Sep 8, 2022
| @@ -1046,6 +1045,14 @@ def validate(self) -> None: | |||
| "`TargetGenerator.moved_field`s, to avoid redundant graph edges." | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def register_plugin_field(cls, field: Type[Field], *, copy_field: bool = False) -> UnionRule: | |||
There was a problem hiding this comment.
@stuhood: Is this an okay API change to make via chery pick to a still alpha branch?
stuhood
approved these changes
Sep 10, 2022
It should be. I just wanted a second opinion on the choice of keyword argument with default as being backwards compatible for |
tdyas
pushed a commit
that referenced
this pull request
Sep 19, 2022
As reported on Slack, after #16799, help for targets with plugin fields was listing those plugin fields multiple times. Remove the override of `register_plugin_field` on `TargetGenerator` since tests seems to pass without that code and the need to set the plugin field as a moved or copied field may be unnecessary if the field is registered on the generator and the generated target types. [ci skip-rust] [ci skip-build-wheels]
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Sep 19, 2022
As reported on Slack, after pantsbuild#16799, help for targets with plugin fields was listing those plugin fields multiple times. Remove the override of `register_plugin_field` on `TargetGenerator` since tests seems to pass without that code and the need to set the plugin field as a moved or copied field may be unnecessary if the field is registered on the generator and the generated target types. [ci skip-rust] [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
Sep 19, 2022
) As reported on Slack, after #16799, help for targets with plugin fields was listing those plugin fields multiple times. Remove the override of `register_plugin_field` on `TargetGenerator` since tests seems to pass without that code and the need to set the plugin field as a moved or copied field may be unnecessary if the field is registered on the generator and the generated target types. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package mapping from import path to addresses (
ImportPathToPackages) was global to the entire repository and not split by Go module. This prevented using multiple Go modules in a single repository. This PR solves the issue by introducingGoImportPathMappingRequestwhich allows the package mapping to be requested per module.That per-module mapping relies on a repository-wide mapping available as
AllGoModuleImportPathsMappings. TheGoModuleImportPathsMappingsHookunion allows plugins to provide their own import path mappings. For example, this support is now used by the protobuf/go codegen backend to supply import paths from generated protobuf code, meaning that the Go backend is able to infer dependencies between Go code and protobuf code automatically.Fixes #13114.
[ci skip-rust]