remove override of register_plugin_field (Cherry pick of #16919) #16923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported on Slack, after pantsbuild#16799, help for targets with plugin fields was listing those plugin fields multiple times. Remove the override of `register_plugin_field` on `TargetGenerator` since tests seems to pass without that code and the need to set the plugin field as a moved or copied field may be unnecessary if the field is registered on the generator and the generated target types. [ci skip-rust] [ci skip-build-wheels]
tdyas
changed the title
stuhood
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Slack, after #16799, help for targets with plugin fields was listing those plugin fields multiple times. Remove the override of
register_plugin_fieldonTargetGeneratorsince tests seems to pass without that code and the need to set the plugin field as a moved or copied field may be unnecessary if the field is registered on the generator and the generated target types.[ci skip-rust]
[ci skip-build-wheels]