Fix issue with python_bundle_create over multiple targets #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tmgardner ! Please see http://www.pantsbuild.org/howto_contribute.html for info on how to post this rbcommons. |
toddgardner
force-pushed
the
tmgardner_fix_python_binaries
branch
from
a4a7e66
to
0b30d7c
Compare
wisechengyi
approved these changes
Apr 5, 2017
|
Oof. I fixed this bug myself a few weeks ago. No need to merge this branch. Although, the test case that @toddgardner has added looks important. As a side note, I've also developed my own docker plugin, which exposed this bug. Now that @toddgardner 's is getting so much press I'm going to work with my company's open source policy such that I can offer it up for feedback. :D |
|
I'm closing this since #4389 was solved by #4390 as noted by @derrley above in master @ afc17b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python_pex_product was being added to the "binary" variable which was from the previous for loop, so what the pex product actually gets added to is just a random target if there's >1. This includes a test which demonstrates the problem.