Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import order issues introduced by a previous commit. #4156

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Fix import order issues introduced by a previous commit. #4156

merged 1 commit into from
Jan 2, 2017

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jan 2, 2017

Also picks up a few other stray issues from before that.

@benjyw
Fix import order issues introduced by a previous commit.
2bda922 
Also picks up a few other stray issues from before that.
@benjyw benjyw requested a review from stuhood January 2, 2017 03:58
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Jan 2, 2017

Not much to review - I ran ./pants fmt.isort :: and this is the result...

@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Jan 2, 2017

Thanks @wisechengyi!

@benjyw benjyw merged commit 1dfd2ff into pantsbuild:master Jan 2, 2017
@benjyw benjyw deleted the fix_import_order branch January 2, 2017 04:06
@benjyw benjyw removed the request for review from stuhood January 2, 2017 04:06
lenucksi pushed a commit to lenucksi/pants that referenced this pull request Apr 25, 2017
@benjyw @lenucksi
Fix import order issues introduced by a previous commit. (pantsbuild#…
8d11251 
…4156)

Also picks up a few other stray issues from before that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisechengyi wisechengyi wisechengyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjyw @wisechengyi