Prepare the 1.3.0.dev6 release.

[mateor]

No description provided.

[stuhood]

It looks like build-support/bin/contributors.sh might not have been run here... at least one of these commits was from a new contributor.

[stuhood]

Looks like this might need a trailing _ to render correctly...?

[mateor]

oh - yep you are right. Will update.

Also - I meant to comment to this affect, but I didn't find a pull request for john's commit. I just linked to the commit itself. Maybe I missed it somewhere...

[mateor]

Hmmm...that release-script gave me unexpected output:

-+ Fiona Condone
++ Fiona
 + Florian Leibert
 + Gabriel Gonzalez
 + Garrett Malmquist
@@ -55,6 +55,7 @@ Created by running `build-support/bin/contributors.sh`.
 + Jason Jackson
 + Jeff Jenkins
 + Jessica Rosenfield
++ JieGhost
 + Jin Feng
 + Joe Crobak
 + Joe Ennever
@@ -135,3 +136,4 @@ Created by running `build-support/bin/contributors.sh`.
 + Wolfram Arnold
 + Yi Cheng
 + Yujie Chen
++ nsaechao
(END)

Will need to dig a bit here...

[mateor]

I am pressed for time, so I am going to take the easy way out and add the affected names to the mailmap. Will open an issue for future triage.

[jsirois]

@mateor - that's the correct response, no need to undo.

History indicates the original add may have been manual or at least manually edited to add the last name:

$ git log | grep -i fiona
Author: Fiona <fiona@giphy.com>
$ git grep -i fiona
CONTRIBUTORS.md:+ Fiona Condone
$ git blame CONTRIBUTORS.md | grep -i fiona
f0daa0b54d (Yi Cheng          2016-12-09 00:38:17 -0800  42) + Fiona Condone

Also, the commit of mine with no PR had no PR - I directly submitted w/o review to get release out.

[wisechengyi]

ha right. I had to look up slack to know her last name

[mateor]

Ah, okay - thanks. Should be all set for the next releaser - I mapped the ones that were previously done manually.

[jsirois]

Also:

$ git log | grep Yujie | grep Author | sort | uniq -c
     27 Author: Yujie Chen <yujieproject@gmail.com>
$ git log | grep JieGhost | grep Author | sort | uniq -c
      1 Author: JieGhost <yujieproject@gmail.com>

So Yujie either changed machines or changed his gitconfig for this latest commit.

And

$ git log | grep nsaechao
Author: nsaechao <nysaechao@outlook.com>

So that's just the way it is unless you have mailing list or slack info to indicate a real name.

[wisechengyi]

nsaechao is Ny Saechao

[mateor]

Thanks @wisechengyi - updated!

[mateor]

The free Commit link looks a bit funny in the diff - but the render appears okay

[stuhood]

Thanks Mateo.