Get rid of resources=[] stanzas in our JVMTargets. #4247

Merged
merged 1 commit into from Feb 11, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Feb 11, 2017

Resources targets can, and should, just be regular dependencies.
We should probably deprecate resources=[], there's no good reason for it to exist.

Note that nothing changes for PythonTargets, where resources= are filesets.

Get rid of resources=[] stanzas in our JVMTargets.
Resources targets can, and should, just be regular dependencies.
We should probably deprecate resources=[], there's no good reason for it to exist.

Note that nothing changes for PythonTargets, where resources= are filesets.
@stuhood

Would love to see a deprecation of this argument if you have time for it!

@benjyw benjyw merged commit 258a661 into pantsbuild:master Feb 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:bundle_create_test_tweak branch Feb 11, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Get rid of resources=[] stanzas in our JVMTargets. (#4247)
Resources targets can, and should, just be regular dependencies.
We should probably deprecate resources=[], there's no good reason for it to exist.

Note that nothing changes for PythonTargets, where resources= are filesets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment