Get rid of resources=[] stanzas in our JVMTargets. #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources targets can, and should, just be regular dependencies. We should probably deprecate resources=[], there's no good reason for it to exist. Note that nothing changes for PythonTargets, where resources= are filesets.
stuhood
approved these changes
Feb 11, 2017
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
Resources targets can, and should, just be regular dependencies. We should probably deprecate resources=[], there's no good reason for it to exist. Note that nothing changes for PythonTargets, where resources= are filesets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources targets can, and should, just be regular dependencies.
We should probably deprecate resources=[], there's no good reason for it to exist.
Note that nothing changes for PythonTargets, where resources= are filesets.