Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scalastyle and java checkstyle into the lint goal #4540

Merged
merged 2 commits into from May 2, 2017
Merged

Move scalastyle and java checkstyle into the lint goal #4540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6c7da
Move scalastyle and javastyle into the core
stuhood May 2, 2017
58c7ea9
Remove stale optional references.
stuhood May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion build-support/bin/release.sh
View file
Open in desktop
Expand Up @@ -84,7 +84,6 @@ function execute_packaged_pants_with_internal_backends() {
'pants.backend.jvm',\
'pants.backend.project_info',\
'pants.backend.python',\
'internal_backend.optional',\
'internal_backend.repositories',\
'internal_backend.sitegen',\
'internal_backend.utilities',\
Expand Down
1 change: 0 additions & 1 deletion contrib/README.md
View file
Open in desktop
Expand Up @@ -48,7 +48,6 @@ Contrib plugins should generally follow 3 basic setup steps:
]

backend_packages: [
"internal_backend.optional",
"internal_backend.repositories",
"internal_backend.sitegen",
"internal_backend.utilities",
Expand Down
1 change: 0 additions & 1 deletion pants-plugins/src/python/internal_backend/BUILD
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@
target(
name='plugins',
dependencies = [
'pants-plugins/src/python/internal_backend/optional:plugin',
'pants-plugins/src/python/internal_backend/repositories:plugin',
'pants-plugins/src/python/internal_backend/sitegen:plugin',
'pants-plugins/src/python/internal_backend/utilities:plugin',
Expand Down
13 changes: 0 additions & 13 deletions pants-plugins/src/python/internal_backend/optional/BUILD
View file
Open in desktop

This file was deleted.

Empty file removed pants-plugins/src/python/internal_backend/optional/__init__.py
View file
Open in desktop
Empty file.
15 changes: 0 additions & 15 deletions pants-plugins/src/python/internal_backend/optional/register.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pants.ini
View file
Open in desktop
Expand Up @@ -40,7 +40,6 @@ pythonpath: [

backend_packages: +[
"pants.backend.docgen",
"internal_backend.optional",
"internal_backend.repositories",
"internal_backend.sitegen",
"internal_backend.utilities",
Expand Down
8 changes: 7 additions & 1 deletion src/python/pants/backend/jvm/register.py
View file
Open in desktop
Expand Up @@ -35,6 +35,7 @@
from pants.backend.jvm.tasks.bootstrap_jvm_tools import BootstrapJvmTools
from pants.backend.jvm.tasks.bundle_create import BundleCreate
from pants.backend.jvm.tasks.check_published_deps import CheckPublishedDeps
from pants.backend.jvm.tasks.checkstyle import Checkstyle
from pants.backend.jvm.tasks.classmap import ClassmapTask
from pants.backend.jvm.tasks.consolidate_classpath import ConsolidateClasspath
from pants.backend.jvm.tasks.detect_duplicates import DuplicateDetector
Expand All @@ -61,6 +62,7 @@
from pants.backend.jvm.tasks.scala_repl import ScalaRepl
from pants.backend.jvm.tasks.scaladoc_gen import ScaladocGen
from pants.backend.jvm.tasks.scalafmt import ScalaFmtCheckFormat, ScalaFmtFormat
from pants.backend.jvm.tasks.scalastyle import Scalastyle
from pants.backend.jvm.tasks.unpack_jars import UnpackJars
from pants.base.deprecated import warn_or_error
from pants.build_graph.build_file_aliases import BuildFileAliases
Expand Down Expand Up @@ -197,12 +199,16 @@ def register_goals():
task(name='junit', action=JUnitRun).install('test')
task(name='bench', action=BenchmarkRun).install('bench')

# Linting.
task(name='scalafmt', action=ScalaFmtCheckFormat, serialize=False).install('lint')
task(name='scalastyle', action=Scalastyle, serialize=False).install('lint')
task(name='checkstyle', action=Checkstyle, serialize=False).install('lint')

# Running.
task(name='jvm', action=JvmRun, serialize=False).install('run')
task(name='jvm-dirty', action=JvmRun, serialize=False).install('run-dirty')
task(name='scala', action=ScalaRepl, serialize=False).install('repl')
task(name='scala-dirty', action=ScalaRepl, serialize=False).install('repl-dirty')
task(name='scalafmt', action=ScalaFmtCheckFormat, serialize=False).install('lint', first=True)
task(name='scalafmt', action=ScalaFmtFormat, serialize=False).install('fmt')
task(name='test-jvm-prep-command', action=RunTestJvmPrepCommand).install('test', first=True)
task(name='binary-jvm-prep-command', action=RunBinaryJvmPrepCommand).install('binary', first=True)
Expand Down