An --eager option for BootstrapJvmTools. #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces the bootstrap task to resolve all known tools eagerly instead of lazily. Useful, e.g., for creating warmed-up Pants workspaces in Docker images.
stuhood
approved these changes
Jan 17, 2018
| if self.get_options().eager: | ||
| for scope, callbacks_by_key in callback_product_map.items(): | ||
| for key, callback in callbacks_by_key.items(): | ||
| self.context.log.info('Eagerly resolving {} for scope {}.'.format(key, scope)) |
There was a problem hiding this comment.
Rather than including eager in the log message, maybe put eager resolution under a workunit? Would have the advantage of making it easier to track.
There was a problem hiding this comment.
I.e., a single workunit that contains all the resolution workunits? That works.
stuhood
approved these changes
Jan 17, 2018
|
CI passes except for waiting for OSX shard. Merging. |
stuhood
pushed a commit
that referenced
this pull request
Jan 18, 2018
Forces the bootstrap task to resolve all known tools eagerly instead of lazily. Useful, e.g., for creating warmed-up Pants workspaces in Docker images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces the bootstrap task to resolve all known tools eagerly
instead of lazily.
Useful, e.g., for creating warmed-up Pants workspaces in
Docker images.