New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An --eager option for BootstrapJvmTools. #5336

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

benjyw commented Jan 17, 2018

Forces the bootstrap task to resolve all known tools eagerly
instead of lazily.

Useful, e.g., for creating warmed-up Pants workspaces in
Docker images.

An --eager option for BootstrapJvmTools.
Forces the bootstrap task to resolve all known tools eagerly
instead of lazily.

Useful, e.g., for creating warmed-up Pants workspaces in
Docker images.

@benjyw benjyw requested a review from baroquebobcat Jan 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks, great idea!

if self.get_options().eager:
for scope, callbacks_by_key in callback_product_map.items():
for key, callback in callbacks_by_key.items():
self.context.log.info('Eagerly resolving {} for scope {}.'.format(key, scope))

This comment has been minimized.

@stuhood

stuhood Jan 17, 2018

Member

Rather than including eager in the log message, maybe put eager resolution under a workunit? Would have the advantage of making it easier to track.

This comment has been minimized.

@benjyw

benjyw Jan 17, 2018

Contributor

I.e., a single workunit that contains all the resolution workunits? That works.

This comment has been minimized.

@benjyw

benjyw Jan 17, 2018

Contributor

Done!

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Jan 18, 2018

CI passes except for waiting for OSX shard. Merging.

@benjyw benjyw merged commit 547578d into pantsbuild:master Jan 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@benjyw benjyw deleted the benjyw:eager-jvm-tool-bootstrap branch Jan 18, 2018

stuhood added a commit that referenced this pull request Jan 18, 2018

An --eager option for BootstrapJvmTools. (#5336)
Forces the bootstrap task to resolve all known tools eagerly
instead of lazily.

Useful, e.g., for creating warmed-up Pants workspaces in
Docker images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment