Memoize stable task creation #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate instances for separate runs of `Goal`.
jsirois
approved these changes
Apr 4, 2018
stuhood
force-pushed
the
stuhood/memoize-stable-task-creation
branch
from
d9cd10d
to
2adf57c
Compare
benjyw
approved these changes
Apr 4, 2018
| task1_pre, = install() | ||
| Goal.clear() | ||
| task1_post, = install() | ||
| self.assertEquals(task1_pre, task1_post) |
There was a problem hiding this comment.
Do you want to check that they have the same id? Or is semantic equality all we actually care about anyway?
There was a problem hiding this comment.
Semantic equality is really what matters, yea. Although in theory I could/should have checked __hash__ as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After
Goal.clear(), task subclasses created for the same superclasses and scopes will not be equal/identical to those from beforeGoal.clear().As part of its maintenance of the task/goal lifecycle,
pantsdclears the goals, which currently causes the creation of multiple non-identical but otherwise equal subclasses, and that caused me some confusion on #5639 where I was attempting to use task classes as dict keys.Solution
Memoize creation of the stable task subclasses (similar to the strategy used in
Collection.of).Result
Task classes behave as expected in #5639.