Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch to a per-entry state machine in Graph #6013
#4558 introduces a new state for a
Additionally, we have seen that
In order to make #4558 easier to implement correctly (and to reduce memory usage), implement the storage of a
One of the largest complexities of
This change reduces memory usage about 200MB further than the fix from #5990 (down to about 2.5GB for
This also fixes #3695, as since we now fail slowly, we are able to render multiple distinct failures at once.
This depends on #6010.
From profiling, I believe I have a handle on why we see a performance regression: because
There are two concrete improvements possible:
The final error in Travis is related to #3695, because this change has the effect of making pantsd fail slowly: in essence, all nodes that have already been requested will complete (although a user request will still fail fast). This might cause traces to render more than they should.