skip integration test with pants_requirement() #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, this test passing requires the version of pants specified in `src/python/pants/VERSION` to have been released to pypi. this makes it difficult for release candidates to pass testing.
This was referenced Sep 12, 2018
|
Had to restart a couple of integration test shards due to travis timeouts during some pantsd testing (which I just barely forgot to keep the logs for). Will watch if the timeout occurs again. |
cosmicexplorer
added a commit
that referenced
this pull request
Sep 12, 2018
### Problem Spent a bit more time thinking after #6493 and there's no reason we need to test the case of a `pants_requirement()` in a `python_dist()`'s `setup_requires` -- as @jsirois said in #6490, these are both well-tested at lower levels, and the increase in CI time alone, even if it worked, is enough to make this removal-worthy. ### Solution - Delete `examples/src/python/example/python_distribution/hello/pants_setup_requires/` and `test_pants_requirement_setup_requires_version`, which is the broken test that depends on it. ### Result This was intentionally separated from #6493 so we can have absolutely no fear of merging that first to fix CI. Resolves #6490.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #6490. Currently,
test_pants_requirement_setup_requires_versionrequires the version of pants specified insrc/python/pants/VERSIONto have been released to pypi. This makes it somewhat difficult for release candidates to pass CI.Solution
test_pants_requirement_setup_requires_versionto unbreak release CI. This is the only references to thepants_setup_requirestarget I can find in the repo.Result
I don't necessarily think that depending on a
pants_requirement()in apython_dist()'ssetup_requiresneeds to be tested in CI, and I haven't figured out whether it's appropriate to delete this test entirely. Either way, that will be figured out in a followup diff.