delete unnecessary testproject and broken test #6494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spent a bit more time thinking after #6493 and there's no reason we need to test the case of a
pants_requirement()
in apython_dist()
'ssetup_requires
-- as @jsirois said in #6490, these are both well-tested at lower levels, and the increase in CI time alone, even if it worked, is enough to make this removal-worthy.Solution
examples/src/python/example/python_distribution/hello/pants_setup_requires/
andtest_pants_requirement_setup_requires_version
, which is the broken test that depends on it.Result
This was intentionally separated from #6493 so we can have absolutely no fear of merging that first to fix CI. Resolves #6490.