Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node.js to 8.11.3 and Yarn to 1.6.0 #6512

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Upgrade Node.js to 8.11.3 and Yarn to 1.6.0 #6512

merged 1 commit into from
Sep 18, 2018

Conversation

nsaechao
Copy link
Contributor

Problem

The version of Node.js and Yarnpkg in Pants is outdated by a year. This is duplicating #6341, but has fixes to the Travis CI test failures.

Solution

Upgrade Node.js to v8.11.3 and Yarnpkg to v1.6.0

Result

Node.js is by default v8.11.3 and Yarnpkg to v1.6.0

stuhood
stuhood approved these changes Sep 18, 2018
View reviewed changes
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One shard flaked: have restarted it. Will merge on green.

@stuhood stuhood merged commit 3a064e8 into pantsbuild:master Sep 18, 2018
@stuhood
Copy link
Sponsor Member

stuhood commented Sep 18, 2018

Thanks!

@nsaechao
Copy link
Contributor Author

Thanks @stuhood!

@nsaechao nsaechao mentioned this pull request Sep 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsaechao @stuhood