Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantsd client logs exceptions from server processes #6539

Merged
merged 7 commits into from
Sep 22, 2018
Merged

pantsd client logs exceptions from server processes #6539

merged 7 commits into from
Sep 22, 2018

Commits on Sep 20, 2018

  1. Guarantee a pantsd pid is available for the purposes of error handling.

    @stuhood
    stuhood committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    b41f360 View commit details
    Browse the repository at this point in the history

  2. Move ExceptionSink setup as early as possible.

    @stuhood
    stuhood committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    fec8986 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Capture a remote exception log if possible.

    @stuhood
    stuhood committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    945381c View commit details
    Browse the repository at this point in the history

  2. (re)-create the exception log path during every attempt to write an e… 

    …xception.
    @stuhood
    stuhood committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    7ff5267 View commit details
    Browse the repository at this point in the history

  3. Add a (currently failing) test that we capture a remote exception in … 

    …the pantsd client when a pantsd-runner is killed.
    @stuhood
    stuhood committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    51f7cdb View commit details
    Browse the repository at this point in the history

  4. Review feedback.

    @stuhood
    stuhood committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    a2d2686 View commit details
    Browse the repository at this point in the history

  5. xfail the test that will be fixed by pantsbuild#6530.

    @stuhood
    stuhood committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    7649844 View commit details
    Browse the repository at this point in the history