Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create exactly one associated subsystem per checkstyle plugin #6634

Merged
merged 3 commits into from
Oct 16, 2018
Merged

Create exactly one associated subsystem per checkstyle plugin #6634

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1eb78a1
Each call to this method created a new instance of the class, which c…
stuhood Oct 16, 2018
4f3a9aa
Add docstring.
stuhood Oct 16, 2018
c51f54a
Remove extra `r`.
Oct 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...b/python/src/python/pants/contrib/python/checks/tasks/checkstyle/plugin_subsystem_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import json

from pants.subsystem.subsystem import Subsystem
from pants.util.memo import memoized


class PluginSubsystemBase(Subsystem):
Expand All @@ -28,6 +29,7 @@ def options_blob(self):
return json.dumps(options_dict) if options_dict else None


@memoized
def default_subsystem_for_plugin(plugin_type):
return type(str('{}Subsystem'.format(plugin_type.__name__)),
(PluginSubsystemBase,),
Expand Down