Make bootstrap jar reproducible #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add some tests to this PR shortly |
No pesky timestamps
illicitonion
force-pushed
the
dwagnerhall/reproduciblezip
branch
from
0a99cb5
to
e3cd873
Compare
stuhood
approved these changes
Nov 21, 2018
| @@ -0,0 +1,2 @@ | |||
| Files taken from https://github.com/facebook/buck at sha aedaec64909a4c54f3d8b6b6db5f779f18f85f75. | |||
| Licence is Apache 2. | |||
There was a problem hiding this comment.
Pesky Americans
|
Simplified quite a bit, added a test - PTAL :) |
stuhood
approved these changes
Nov 21, 2018
|
Yeah, timestamps are preserved; we should explicitly scrub anything we want to be consistent, because the scrubber does more things (e.g. scrubs the central area) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No pesky timestamps