New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrap jar reproducible #6796

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 20, 2018

No pesky timestamps

@illicitonion illicitonion requested review from stuhood and blorente Nov 20, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 20, 2018

Will add some tests to this PR shortly

Make bootstrap jar reproducible
No pesky timestamps

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/reproduciblezip branch from 0a99cb5 to e3cd873 Nov 20, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks, looks good.

@@ -0,0 +1,2 @@
Files taken from https://github.com/facebook/buck at sha aedaec64909a4c54f3d8b6b6db5f779f18f85f75.
Licence is Apache 2.

This comment has been minimized.

@stuhood

stuhood Nov 21, 2018

Member

License

This comment has been minimized.

@illicitonion

illicitonion Nov 21, 2018

Contributor

Pesky Americans

Simplify
* Just use ZipScrubber
* Add test
@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 21, 2018

Simplified quite a bit, added a test - PTAL :)

@stuhood
Copy link
Member

stuhood left a comment

Looks good, thanks. This will no longer apply to "all" tools that we bootstrap though... although if those are preserving the timestamps in existing ZipEntrys, then maybe that's fine.

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 22, 2018

Yeah, timestamps are preserved; we should explicitly scrub anything we want to be consistent, because the scrubber does more things (e.g. scrubs the central area)

@illicitonion illicitonion merged commit ea1ab42 into pantsbuild:master Nov 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/reproduciblezip branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment