Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pants_runtime_python_version global option #7363

Merged

Commits on Mar 12, 2019

  1. Configuration menu
    Copy the full SHA
    8a53513 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    307ac94 View commit details
    Browse the repository at this point in the history
  3. Move comments directly into help argument

    Danny and Stu have a point that it's better to expose this info directly to the user, rather than keeping it in a comment in source code.
    
    I originally was thinking we'd want to keep the help message shorter, and rely on the message in the runtime check to steer people the right way, but this is bad reasoning. I can't think of a time I was upset a help message was too long (so long as it was concise and everything had a reason to be there)..
    Eric-Arellano committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    5f151b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d47c523 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Rename pants_engine_python_version to pants_runtime_python_version + …

    …improve comments
    
    Make explicit reference to the setup repo and our ./pants script we distribute. The average user will end up wanting to use this script, so it's good to remind them that we will parse these versions and resolve them automatically.
    Eric-Arellano committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    0df9ae3 View commit details
    Browse the repository at this point in the history