Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup run_python_test rule. #7577

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Cleanup run_python_test rule. #7577

merged 1 commit into from
Apr 16, 2019

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Apr 16, 2019

Get rid of PATH env var by executing pexes using an interpreter
directly to avoid /usr/bin/env shebang evaluation of PATH.

DRY up requirements pex name further.

@jsirois
Cleanup run_python_test rule.
341bcb3 
Get rid of PATH env var by executing pexes using an interpreter
directly to avoid /usr/bin/env shebang evaluation of PATH.

DRY up requirements pex name further.
cosmicexplorer
cosmicexplorer approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This actually makes it much more clear how to make the thing hermetic too (just obtain a snapshot of a python interpreter somehow)!

illicitonion
illicitonion approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuhood stuhood merged commit a33fc0b into pantsbuild:master Apr 16, 2019
@jsirois jsirois deleted the run_python_test/cleanups branch April 19, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@illicitonion illicitonion illicitonion approved these changes

@cosmicexplorer cosmicexplorer cosmicexplorer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsirois @stuhood @illicitonion @cosmicexplorer