Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup run_python_test rule. #7577

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@jsirois
Copy link
Member

commented Apr 16, 2019

Get rid of PATH env var by executing pexes using an interpreter
directly to avoid /usr/bin/env shebang evaluation of PATH.

DRY up requirements pex name further.

Cleanup run_python_test rule.
Get rid of PATH env var by executing pexes using an interpreter
directly to avoid /usr/bin/env shebang evaluation of PATH.

DRY up requirements pex name further.

@jsirois jsirois requested review from cosmicexplorer and illicitonion Apr 16, 2019

@cosmicexplorer
Copy link
Contributor

left a comment

Yes! This actually makes it much more clear how to make the thing hermetic too (just obtain a snapshot of a python interpreter somehow)!

@illicitonion
Copy link
Contributor

left a comment

Thanks!

@stuhood stuhood merged commit a33fc0b into pantsbuild:master Apr 16, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@jsirois jsirois deleted the jsirois:run_python_test/cleanups branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.