Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GracefulTerminationException with PantsRunFinishedWithFailure… #7671

Conversation

Projects
None yet
3 participants
@blorente
Copy link
Contributor

commented May 7, 2019

Solves #7652

@blorente blorente requested review from stuhood, ity, cosmicexplorer and patliu85 May 7, 2019

@ity

ity approved these changes May 7, 2019

Copy link
Contributor

left a comment

thanks!

@stuhood

stuhood approved these changes May 7, 2019

Copy link
Member

left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@blorente : It looks like this conflicted with the landing of Patrick's change, which caused that test to fail in your shards. Assuming that test is the only one that fails, you should be good to merge.

@blorente blorente merged commit b7c4cf3 into pantsbuild:master May 7, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.