Fix remoting of V2 Python test runnner not being able to discover the Python interpreter #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Separately from the interpreter PEX uses to run Pytest and to resolve requirements, we must also have an interpreter to run PEX itself. This might be the same interpreter used by Pytest, but need not be, so long as it is Python 2.7 or 3.4+.
Currently, we use
sys.executableto determine this interpreter. This works when running locally, but fails when remoting becausesys.executableis an absolute path, such as'/Users/eric/DocsLocal/code/projects/pants/build-support/pants_dev_deps.py36.venv/bin/python'.Solution
Use a generic
pythonbin name.Result
Local execution still works as expected, including choosing a Python 2 vs. Python 3 interpreter via
--python-setup-interpreter-constraints.While remoting still fails due to other issues, this issue no longer causes an error.