Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize all tests of NailgunTask subclasses. #7866

Merged
merged 2 commits into from Jun 9, 2019
Merged

Stabilize all tests of NailgunTask subclasses. #7866

merged 2 commits into from Jun 9, 2019

Commits on Jun 9, 2019

  1. Stabilize all tests of NailgunTask subclasses. 

    Previously we did this piecemeal and left out the `JarTask` test for
one. This led to problems in CI under the v2 runner's highly parallel
regime. Since there is no need to re-test nailgun behavior for each
`NailgunTask` subclass, turn off nailgunning in unit tests.

Fixes pantsbuild#7865
    @jsirois
    jsirois committed Jun 9, 2019
    Copy the full SHA
    0a1f87e View commit details
    Browse the repository at this point in the history

  2. Fixup associated BUILD deps.

    @jsirois
    jsirois committed Jun 9, 2019
    Copy the full SHA
    fcbaac2 View commit details
    Browse the repository at this point in the history