Use argfile support in zinc and rsc #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
pushed a commit
that referenced
this pull request
Jun 7, 2019
|
The bottom two commits here are from #7861, which cleaned up the arguments in the |
stuhood
force-pushed
the
stuhood/use-argfiles-with-zinc-and-rsc
branch
2 times, most recently
from
efccd68
to
f5ff4ae
Compare
|
Commits are useful to review independently. |
|
Although this is merge-conflicted due to the bottom two patches, it was green in https://travis-ci.org/pantsbuild/pants/builds/542554975 . Would appreciate folks taking a look! |
stuhood
force-pushed
the
stuhood/use-argfiles-with-zinc-and-rsc
branch
from
f5ff4ae
to
60432ac
Compare
stuhood
added a commit
that referenced
this pull request
Jun 7, 2019
### Problem In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of #6803, `zinc` supports `@argfile`s, and `rsc` has supported them for a while. ### Solution Use `@argfile` support in all environments (to minimize variability). ### Result subprocess and hermetic modes scale to larger contexts.
cattibrie
pushed a commit
to cattibrie/pants
that referenced
this pull request
Jun 19, 2019
### Problem In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of pantsbuild#6803, `zinc` supports `@argfile`s, and `rsc` has supported them for a while. ### Solution Use `@argfile` support in all environments (to minimize variability). ### Result subprocess and hermetic modes scale to larger contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of #6803,
zincsupports@argfiles, andrschas supported them for a while.Solution
Use
@argfilesupport in all environments (to minimize variability).Result
subprocess and hermetic modes scale to larger contexts.