Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argfile support in zinc and rsc #7868

Merged

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

commented Jun 7, 2019

Problem

In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of #6803, zinc supports @argfiles, and rsc has supported them for a while.

Solution

Use @argfile support in all environments (to minimize variability).

Result

subprocess and hermetic modes scale to larger contexts.

stuhood added a commit that referenced this pull request Jun 7, 2019

Migrate zinc compiler to scopt and add argfile support (#6803)
Fixes #6487, and unblocks using `@argfiles` with zinc in #7868.
@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

The bottom two commits here are from #7861, which cleaned up the arguments in the rsc task.

@stuhood stuhood marked this pull request as ready for review Jun 7, 2019

@stuhood stuhood force-pushed the twitter:stuhood/use-argfiles-with-zinc-and-rsc branch 2 times, most recently from efccd68 to f5ff4ae Jun 7, 2019

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Commits are useful to review independently.

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Although this is merge-conflicted due to the bottom two patches, it was green in https://travis-ci.org/pantsbuild/pants/builds/542554975 . Would appreciate folks taking a look!

@stuhood stuhood force-pushed the twitter:stuhood/use-argfiles-with-zinc-and-rsc branch from f5ff4ae to 60432ac Jun 7, 2019

@cosmicexplorer
Copy link
Contributor

left a comment

Awesome!

@stuhood stuhood merged commit 1c749f7 into pantsbuild:master Jun 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/use-argfiles-with-zinc-and-rsc branch Jun 7, 2019

stuhood added a commit that referenced this pull request Jun 7, 2019

Use argfile support in zinc and rsc (#7868)
### Problem

In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of #6803, `zinc` supports `@argfile`s, and `rsc` has supported them for a while. 

### Solution

Use `@argfile` support in all environments (to minimize variability).

### Result

subprocess and hermetic modes scale to larger contexts.

cattibrie added a commit to cattibrie/pants that referenced this pull request Jun 19, 2019

Use argfile support in zinc and rsc (pantsbuild#7868)
### Problem

In hermetic and subprocess environments, large targets can fail with "argument list too long" errors. As of pantsbuild#6803, `zinc` supports `@argfile`s, and `rsc` has supported them for a while. 

### Solution

Use `@argfile` support in all environments (to minimize variability).

### Result

subprocess and hermetic modes scale to larger contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.