rsc re-uses DirectoryDigest from process execution rather than re-snapshotting #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #7858 |
illicitonion
force-pushed
the
dwagnerhall/rsc/avoid-re-snapshotting-2
branch
from
a952759
to
399b9f0
Compare
cosmicexplorer
approved these changes
Jun 7, 2019
| @@ -678,14 +656,13 @@ def _runtool_nonhermetic(self, parent_workunit, classpath, main, tool_name, args | |||
| return runjava_workunit | |||
|
|
|||
| def _runtool(self, args, distribution, | |||
| tgt=None, input_digest=None, output_dir=None): | |||
| tgt=None, input_digest=None, ctx=None): | |||
| @@ -361,7 +337,7 @@ def work_for_vts_rsc(vts, ctx): | |||
| classpath_product = self.context.products.get_data('rsc_mixed_compile_classpath') | |||
| classpath_entries = classpath_product.get_classpath_entries_for_targets(dependencies_for_target) | |||
| for _conf, classpath_entry in classpath_entries: | |||
| classpath_paths.append(classpath_entry.path) | |||
| classpath_paths.append(fast_relpath(classpath_entry.path, get_buildroot())) | |||
There was a problem hiding this comment.
Keeping the path as absolute within the ClasspathEntry itself seems definitely like the right thing to do here -- thanks for making this consistent compared to the first diff I had posted!
|
I might note in the description that this fixes what is almost definitely a quadratic slowdown induced by filesystem traversals -- or perhaps link to #7838 / steal that PR's description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.