Prepare the 1.18.0dev0 release #7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Jun 11, 2019
src/python/pants/notes/master.rst
Outdated
| `PR #7843 <https://github.com/pantsbuild/pants/pull/7843>`_ | ||
|
|
||
| * Cleanup unnecessary code from #7776 for `./pants binary` interpreter constraints (#7842) | ||
| `PR #7776 <https://github.com/pantsbuild/pants/pull/7776>`_ |
There was a problem hiding this comment.
It seems like this should have itself linked as well:
`PR #7842 <https://github.com/pantsbuild/pants/pull/7842>`_
There was a problem hiding this comment.
Ah, good catch, this link is to a referenced commit rather than the PR.
There are times the changelog helper appears to match more greedily than I expect. Is the preference to include links to all referenced PRs (so, in this case both #776 and #7842)?
For now I am going to link just the true PR - happy to restore the additional links if anyone thinks that best.
| @@ -4,6 +4,149 @@ Master Pre-Releases | |||
| This document describes development releases which occur weekly from master, and which have | |||
| not undergone the vetting associated with ``stable`` releases. | |||
|
|
|||
| 1.18.0.dev0 (6/10/2019) | |||
There was a problem hiding this comment.
That appears to have been optimisitc - 6/11/2019.
mateor
force-pushed
the
mateo.release_1.18.0dev0
branch
from
ab2146a
to
86e9426
Compare
cattibrie
pushed a commit
to cattibrie/pants
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.