Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary code from #7776 for `./pants binary` interpreter constraints #7842

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 3, 2019

As pointed out in #7776 (comment), #7776 had an unnecessary use of InterpreterCache to re-validate the constraints, even though that was already done by upstream tasks.

This results in less code and slightly faster performance by avoiding running the validation check twice.

@Eric-Arellano Eric-Arellano requested review from stuhood and jsirois Jun 3, 2019

@stuhood

stuhood approved these changes Jun 4, 2019

Copy link
Member

left a comment

Thanks!

@Eric-Arellano Eric-Arellano merged commit 4cde07a into pantsbuild:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:cleanup-python-binary-constraints branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.