Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --post-compile-merge-dir option in zinc #7917

Merged
merged 4 commits into from Jun 23, 2019

Conversation

Projects
None yet
2 participants
@wisechengyi
Copy link
Contributor

commented Jun 20, 2019

Prerequisite for #7869, so resources like

META-INF/services/
META-INF/services/javax.annotation.processing.Processor

in the z.jar can be added by zinc wrapper instead of post processing by Pants.

@stuhood
Copy link
Member

left a comment

Would be good to clean up the naming before landing, but looks good. Thanks.

Show resolved Hide resolved src/scala/org/pantsbuild/zinc/compiler/BUILD Outdated

wisechengyi added some commits Jun 22, 2019

eh
cmt

@wisechengyi wisechengyi changed the title [wip] Add post-compile merge directory step in zinc Add --post-compile-merge-dir step in zinc Jun 22, 2019

@wisechengyi wisechengyi changed the title Add --post-compile-merge-dir step in zinc Add --post-compile-merge-dir option in zinc Jun 22, 2019

@wisechengyi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

@stuhood any further comment on the naming part, I think --post-compile-merge-dir would do?

@stuhood

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Looks good, thanks!

@wisechengyi wisechengyi merged commit 4aad44d into pantsbuild:master Jun 23, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@wisechengyi wisechengyi deleted the wisechengyi:zinc_wrapper_merge_dir branch Jun 23, 2019

@wisechengyi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

Merged. Please kindly publish zinc wrapper when you get a chance, @stuhood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.