Enable incremental compile for zinc hermetic by adding scratch input digest for local ExecuteProcessRequest #8282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
changed the title
This reverts commit 489220c.
wisechengyi
changed the title
wisechengyi
changed the title
|
Not reviewable yet, but cc @blorente : Yi is currently leaning toward a local-only sidechannel for stashing analysis. Potentially related to other local-only low-latency-JVM options. |
wisechengyi
changed the title
wisechengyi
changed the title
wisechengyi
changed the title
|
This is now ready for review. Thanks! Travis failed at unrelated tests. |
blorente
approved these changes
Sep 20, 2019
tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py
Outdated
Show resolved
Hide resolved
illicitonion
requested changes
Sep 20, 2019
src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py
Outdated
Show resolved
Hide resolved
| return _classes_dir_snapshot | ||
|
|
||
| analysis_snapshot = _get_analysis_snaoshot() | ||
| classes_dir_snapshot = _get_classes_dir_snapshot() |
There was a problem hiding this comment.
Why do we need a classes dir? I thought Zinc could operate purely on jars? If this is necessary, can you add a comment to the code explaining why? This seems pretty weird...
There was a problem hiding this comment.
Indeed. zinc requires loose classfiles in the output directory in order for incremental compile to work.
There was a problem hiding this comment.
zinc was supposed to be headed in the direction of supporting operating on jars... but it didn't get there, unfortunately.
tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py
Outdated
Show resolved
Hide resolved
tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py
Outdated
Show resolved
Hide resolved
stuhood
approved these changes
Sep 21, 2019
| return _classes_dir_snapshot | ||
|
|
||
| analysis_snapshot = _get_analysis_snaoshot() | ||
| classes_dir_snapshot = _get_classes_dir_snapshot() |
There was a problem hiding this comment.
zinc was supposed to be headed in the direction of supporting operating on jars... but it didn't get there, unfortunately.
illicitonion
approved these changes
Sep 23, 2019
src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zinc hermetic does not work with incremental compile
Solution
Add local specific scratch dir for
ExecuteProcessRequestwithunsafe_local_only_files_because_we_favor_speed_over_correctness_for_this_rule: hashing::DigestSimilar to
input_files, except it is ignored in the remote case.Reasoning being
classes/into theinput_filesdigest, it could cause severe performance issue for downloading a lot of loosing files in remoting.