Modernize abc stdlib usage.
#7928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Jun 21, 2019
| Singleton = SingletonMetaclass(u'Singleton', (object,), {}) | ||
| except TypeError: # Python2 | ||
| Singleton = SingletonMetaclass(b'Singleton', (object,), {}) | ||
| Singleton = SingletonMetaclass('Singleton', (object,), {}) |
There was a problem hiding this comment.
This change makes me very happy :)
jsirois
force-pushed
the
abcs/fix_deprecated
branch
2 times, most recently
from
a7d84af
to
91a968c
Compare
|
This is certain to have merge conflicts with #7926, which I'm planning to merge upon green CI in an hour or so. |
Eliminate use of the `deprecated abc.abstractproperty`. See: https://docs.python.org/3/library/abc.html#abc.abstractproperty While in meta.py also simplify the `Singleton` baseclass and simplify the now redundant `AbstractClass` to alias `abc.ABC` with inlining tracked by pantsbuild#7927.
jsirois
force-pushed
the
abcs/fix_deprecated
branch
from
91a968c
to
0d0c31a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate use of the
deprecated abc.abstractproperty. See:https://docs.python.org/3/library/abc.html#abc.abstractproperty
While in meta.py also simplify the
Singletonbaseclass.