New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize classes to use Python 3 syntax #7937
Merged
Eric-Arellano
merged 9 commits into
pantsbuild:master
from
Eric-Arellano:modernize-classes
Jun 23, 2019
Merged
Modernize classes to use Python 3 syntax #7937
Eric-Arellano
merged 9 commits into
pantsbuild:master
from
Eric-Arellano:modernize-classes
Jun 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
jsirois,
benjyw,
cosmicexplorer and
blorente
June 22, 2019 21:41
This depends on #7934 to be merged for green CI. Each commit may be independently reviewed. |
jsirois
approved these changes
Jun 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review of cf1d38d was cursory, but the other commits definitely look good.
It's irrelevant now
SKIP_FULL_CI # Documentation-only change. # Delete this line to force a full CI run for documentation-only changes. SKIP_FULL_CI # Documentation-only change. # Delete this line to force a full CI run for documentation-only changes. SKIP_FULL_CI # Documentation-only change.
I'm not sure why this is necessary, but it is.
Eric-Arellano
force-pushed
the
modernize-classes
branch
from
June 23, 2019 00:45
87ef6fd
to
5684300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 makes it repetitive to subclass
object
and to call the verbose form ofsuper()
.We use this script to update the codebase to use the simpler style, excluding the
contrib.python.checks.checker
package. The main part of this script is these two regex substitutions: