Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 `hashlib.hexdigest()` decoding #7965

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 27, 2019

In Python 2, hashlib.hexdigest() returned a byte string, but unicode in Py3. We adopted an idiom to always return unicode, which we can now remove.

@Eric-Arellano Eric-Arellano requested review from ity and blorente Jun 27, 2019

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Cancelling CI because this requires #7964 to be merged first, so that we can remove a from future.utils import PY3 import.

@Eric-Arellano Eric-Arellano changed the title Remove Python 2 `hashlib.hexdiget()` decoding Remove Python 2 `hashlib.hexdigest()` decoding Jun 28, 2019

@blorente
Copy link
Contributor

left a comment

LGTM :)

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:remove-py2-hexdigest branch from 84d4e23 to a12c7b1 Jun 28, 2019

@Eric-Arellano Eric-Arellano merged commit 159e3b1 into pantsbuild:master Jun 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:remove-py2-hexdigest branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.