Remove Python 2 hashlib.hexdigest() decoding
#7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancelling CI because this requires #7964 to be merged first, so that we can remove a |
Eric-Arellano
changed the title
hashlib.hexdiget() decodinghashlib.hexdigest() decoding
Eric-Arellano
force-pushed
the
remove-py2-hexdigest
branch
from
84d4e23
to
a12c7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2,
hashlib.hexdigest()returned a byte string, but unicode in Py3. We adopted an idiom to always return unicode, which we can now remove.