Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround Travis timeout for OSX platforms test" #7967

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

commented Jun 28, 2019

Reverts #7919, because rather than just taking a long time, the test seems to actually hang.

@Eric-Arellano
Copy link
Contributor

left a comment

Agreed this is the right change. Could you please briefly update the description to explain that the issue is not timeouts, but that the test truly hangs so we do want to keep Travis's default timeout of 10 minutes.

Thanks for reverting this.

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Blargh... that's annoying: clicking the magic "Revert this Commit" button in Github's UI creates a branch on origin which kicks off the push travis run.

@stuhood stuhood merged commit 5ce6754 into master Jun 28, 2019

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the revert-7919-osx-platform-tests branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.