Workaround Travis timeout for OSX platforms test #7919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please feel free to merge this for me to avoid a CI backlog tomorrow @blorente. |
stuhood
approved these changes
Jun 21, 2019
|
This might have been a bad change. I've seen several timeouts of 50 - 60 minutes, which imply to me that the test truly is hanging rather than just taking longer than 10 minutes to print to the screen. If true, this new timeout makes things worse, because it increases the time it takes to see if the test will fail. It would be better to eagerly fail. |
This was referenced Jun 28, 2019
stuhood
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About half of CI runs, the OSX Platform specific tests shard times out due to not receiving output within 10 minutes.
While an even better solution would make the problematic tests faster, this workarounds the problem via Travis's
travis_waitfunction.We wait up to 50 minutes. Usually the test only takes about 20 minutes, but it has been seen to run up to 45 minutes so we conservatively allow it to take up to 50 minutes.