Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Travis timeout for OSX platforms test #7919

Merged
merged 2 commits into from Jun 22, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 21, 2019

About half of CI runs, the OSX Platform specific tests shard times out due to not receiving output within 10 minutes.

While an even better solution would make the problematic tests faster, this workarounds the problem via Travis's travis_wait function.

We wait up to 50 minutes. Usually the test only takes about 20 minutes, but it has been seen to run up to 45 minutes so we conservatively allow it to take up to 50 minutes.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Please feel free to merge this for me to avoid a CI backlog tomorrow @blorente.

@Eric-Arellano Eric-Arellano merged commit f5da4dd into pantsbuild:master Jun 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:osx-platform-tests branch Jun 22, 2019

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

This might have been a bad change. I've seen several timeouts of 50 - 60 minutes, which imply to me that the test truly is hanging rather than just taking longer than 10 minutes to print to the screen.

If true, this new timeout makes things worse, because it increases the time it takes to see if the test will fail. It would be better to eagerly fail.

stuhood added a commit that referenced this pull request Jun 28, 2019

stuhood added a commit that referenced this pull request Jun 28, 2019

Revert "Workaround Travis timeout for OSX platforms test (#7919)" (#7967
)

Reverts #7919, because rather than just taking a long time, the test seems to actually hang.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.