Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of HTTP response size check #8116

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Commits on Aug 16, 2019

  1. Don't check HTTP response size if gzip'd

    This check that the size in bytes of the downloaded file is the same as
    the size given in the HTTP Content-Length header is broken when
    downloading a compressed file. cf.
    https://2.python-requests.org/en/master/user/quickstart/#response-content
    the iter_content method is iterating over the *uncompressed* bytes of
    the file, but the Content-Length header gives the *compressed* lengths
    of the file. So if the transfer-encoding is gzip or deflate, we don't
    expect these two lengths to match and shouldn't be testing that they do
    gshuflin committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    cd44502 View commit details
    Browse the repository at this point in the history