Remote execution: Set RequestMetadata proto header #8373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
stuhood,
pierrechevalier83,
Eric-Arellano and
cattibrie
Eric-Arellano
approved these changes
Oct 4, 2019
illicitonion
force-pushed
the
dwagnerhall/remexec/metadataproto
branch
2 times, most recently
from
feb1870
to
380392f
Compare
This is optional, but provides useful metadata for analysing requests on the server side. We may want to fill in more information in the future.
illicitonion
force-pushed
the
dwagnerhall/remexec/metadataproto
branch
from
380392f
to
7e8e3c9
Compare
|
This appears to have caused CI issues: https://travis-ci.org/pantsbuild/pants/jobs/595201992 |
|
As discussed in slack, the CI issue was probably something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is optional, but provides useful metadata for analysing requests on
the server side.
We may want to fill in more information in the future.