Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run testprojects integration tests with V2 test runner #8426

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Oct 9, 2019

The V2 test runner does not support method level sharding, as V1 does. We cannot keep test_testprojects_integration.py as one single target because it would take far too long to run, and one single flake would mean every test would need to re-run.

Instead, we split up the target into multiple targets based on the source root, such as all antlr code getting its own test file.

This results in:

tests/python/pants_test/projects
├── BUILD
├── __init__.py
├── projects_test_base.py
├── test_antlr_projects_integration.py
├── test_java_examples_integration.py
├── test_java_testprojects_integration.py
├── test_maven_layout_integration.py
├── test_protobuf_projects_integration.py
├── test_python_examples_integration.py
├── test_python_testprojects_integration.py
├── test_scala_examples_integration.py
├── test_scala_testprojects_integration.py
├── test_thrift_projects_integration.py
└── test_wire_projects_integration.py

@Eric-Arellano Eric-Arellano marked this pull request as ready for review October 10, 2019 03:37
@Eric-Arellano Eric-Arellano changed the title WIP: Run testprojects integration tests with V2 test runner Run testprojects integration tests with V2 test runner Oct 10, 2019
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano
Copy link
Contributor Author

The last commit only modifies timeouts, which V2 currently ignores. Given the prior green run, merging.

@Eric-Arellano Eric-Arellano merged commit d9fa077 into pantsbuild:master Oct 10, 2019
@Eric-Arellano Eric-Arellano deleted the v2-testprojects branch October 10, 2019 14:48
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Oct 10, 2019
Eric-Arellano added a commit that referenced this pull request Oct 10, 2019
#8426 had a typo in its BUILD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants